RFR(xxs): [windows] Build broken on VS2010 after "8046148: JEP 158: Unified JVM Logging"

Thomas Stüfe thomas.stuefe at gmail.com
Wed Sep 30 12:40:47 UTC 2015


I would like to hear more opinions, and possibly a sponsor and a reviewer.

In my opinion it makes sense to fix this. The fix is small and cheap and
makes people happy who still work with older versions of VS2010.

Kind Regards, Thomas

On Tue, Sep 29, 2015 at 5:12 PM, Thomas Stüfe <thomas.stuefe at gmail.com>
wrote:

> Ok, I did not check this. Nevermind, then.
>
> Kind Regards, Thomas
>
> On Tue, Sep 29, 2015 at 4:25 PM, Daniel D. Daugherty <
> daniel.daugherty at oracle.com> wrote:
>
>> Ummm... VS2013 is the official compiler for JDK9 and Win*.
>> Why would we want to make a change to permit VS2010 to
>> continue to be used?
>>
>> Dan
>>
>>
>> On 9/29/15 7:58 AM, Thomas Stüfe wrote:
>>
>>> Hi all,
>>>
>>> please review this tiny change. It fixes the build on windows/Visual
>>> Studio
>>> 2010 after "8046148: JEP 158: Unified JVM Logging".
>>>
>>> strtoull() is missing from Visual Studio versions < 2013, but
>>> _strtoui64()
>>> can be used instead.
>>>
>>> webrev:
>>> http://cr.openjdk.java.net/~stuefe/webrevs/8137329/webrev.00/webrev/
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8137329
>>>
>>> Thanks & Kind Regards, Thomas
>>>
>>
>>
>


More information about the hotspot-runtime-dev mailing list