RFR (M): 8078556: Runtime: implement ranges (optionally constraints) for those flags that have them missing

[gerard ziemski]

hi Dmitry,

On 09/30/2015 07:31 AM, Dmitry Dmitriev wrote:
> Hi Gerard,
>
> Two additional comments:
> 1) Coleen comment about Shared* flags remind me that we need take into account flags relationship and in case of
> Shared*Size flags we need to add "-Xshare:dump" when testing. Can you please add following to the 'switch' statement in
> addNameDependency method(test/runtime/CommandLine/OptionsValidation/common/optionsvalidation/JVMOptionsUtils.java module):
> case "SharedBaseAddress":
> case "SharedMiscCodeSize":
> case "SharedMiscDataSize":
> case "SharedReadOnlySize":
> case "SharedReadWriteSize":
> case "SharedSymbolTableBucketSize":
>        option.addPrepend("-Xshare:dump");
>        break;
>

Good catch, fixed.


> I will also look into other dependencies.
>
> 2) I noticed that you remove processing of  "XX:MaxDirectMemorySize" flag from src/share/vm/runtime/arguments.cpp. Range
> check is covered by new framework, but in this case we also lose ability to specify "XX:MaxDirectMemorySize" with
> following values: "10m", "1g" and etc. This probably can affect users. I prefer to leave that processing, but change
> error message to the standard error message: "Improperly specified VM option 'MaxDirectMemorySize=<value>'
>

This in fact seems to work as expected - I just tested it out.


cheers