RFR (S) round 2 for 8135195 VM Options file should not be limited to 1024 bytes
Daniel D. Daugherty
daniel.daugherty at oracle.com
Wed Sep 30 16:51:18 UTC 2015
On 9/30/15 10:31 AM, Ron Durbin wrote:
> Here is the round 2 webrev for 8135195
> This latest version like the round 1 version of the fix is much simpler than the previous round 0 version so no delta webrev is provided.
>
> Webrev link:
> http://cr.openjdk.java.net/~rdurbin/8135195_OCR2_JDK9_webrev
src/share/vm/runtime/arguments.cpp
I guess you missed seeing my comment on the previous round.
Repeat here:
L3510: "Could not stat options file %s'\n",
Missing a single quote before the %s.
Thumbs up. I don't need to see a new webrev for fixing
the above comment.
Dan
>
> RFE request:
> https://bugs.openjdk.java.net/browse/JDK-8135195
>
> This RFE removes the limitation on the size of VM Options files. That
> limit is currently 1K bytes.
> Removing that limit will allow options files to be read with no
> practical size limit.
>
> This feature has been tested on:
> OS:
> Solaris, MAC, Windows, Linux
> Tests:
> Manual unit test
> JPRT with -testset hotspot (including the SQE proposed test
> coverage for this feature.)
More information about the hotspot-runtime-dev
mailing list