RFR(S) 8153115: Move private interface check to linktime

Lois Foltan lois.foltan at oracle.com
Tue Apr 5 16:30:27 UTC 2016


Hi Igor,

I know you have two reviews for this but could you hold off committing 
until I or Karen Kinnear have a chance to review.  We both worked in 
this area a lot to support default methods in JDK 8. Also, have you run 
the hotspot/test/runtime/SelectionResolution tests on this?

Thanks,
Lois

On 4/1/2016 2:28 PM, Igor Veresov wrote:
> When invoking private interface methods with invokeinterface we throw ICCE. The check for that happens in the runtime part of the resolution, however, doing it at linktime seems like a better place, since the check doesn't depend on the receiver type. It also allows compiler interfaces that rely on linktime resolution to detect inconsistencies during parsing (see ciEnv::lookup_method() (CI) and ConstantPool.lookupMethod() (JVMCI) that are affected).
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8153115
> Webrev: http://cr.openjdk.java.net/~iveresov/8153115/webrev.00/
>
> Thanks,
> igor



More information about the hotspot-runtime-dev mailing list