RFR(xs): JDK-8152329: jvm should treat the "Multi-Release" jar manifest attribute name as case insensitive

Jiangli Zhou jiangli.zhou at oracle.com
Tue Apr 5 17:44:52 UTC 2016


Hi Calvin,

Have you thought about using strcasecmp()? The globalDefinitions_visCPP.hpp defines strcasecmp to _stricmp. So compiler dependency is not an issue. We have existing code that uses strcasecmp() for case insensitive comparison.

// Non-standard stdlib-like stuff:
inline int strcasecmp(const char *s1, const char *s2) { return _stricmp(s1,s2); }

Thanks,
Jiangli
 
> On Apr 4, 2016, at 2:07 PM, Calvin Cheung <calvin.cheung at oracle.com> wrote:
> 
> 
> Please review this small fix for:
> https://bugs.openjdk.java.net/browse/JDK-8152329
> 
> The fix is to convert the buffer containing the jar manifest into lower case before performing strstr.
> 
> webrev: http://cr.openjdk.java.net/~ccheung/8152329/webrev.01/
> 
> Testing:
>    JPRT -testset hotspot
>    The tests under runtime on the platforms built by JPRT.
> 
> thanks,
> Calvin



More information about the hotspot-runtime-dev mailing list