RFR: 8152896: Convert PrintCompressedOopsMode to Unified Logging
Coleen Phillimore
coleen.phillimore at oracle.com
Tue Apr 5 19:55:08 UTC 2016
http://cr.openjdk.java.net/~rprotacio/8152896.00/test/runtime/logging/CompressedOopsTest.java.html
I think the test needs to have a @requires 64 bit rather than.
55 if (Platform.is64bit()) {
around part of it, because this -XX:+UseCompressedOops is unrecognized
unless it's 64 bits.
67 pb = ProcessTools.createJavaProcessBuilder("-XX:+UseCompressedOops",
The code changes look good to me.
Coleen
On 4/5/16 2:00 PM, Rachel Protacio wrote:
> Hello,
>
> Please review this change, converting -XX:+PrintCompressedOopsMode to
> -Xlog:gc+heap. The existing diagnostic flag has been aliased to the
> info level of this tagset (for the "Heap address" message that for
> example appears in the hs_err file), and there are both debug and
> trace levels of logging available as well, as per our established
> schema for assigning levels.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8152896
> Open webrev: http://cr.openjdk.java.net/~rprotacio/8152896.00/
>
> Passes JPRT and RBT quick/non-colo tests.
>
> Thanks!
> Rachel
More information about the hotspot-runtime-dev
mailing list