RFR: 8152896: Convert PrintCompressedOopsMode to Unified Logging
Rachel Protacio
rachel.protacio at oracle.com
Wed Apr 6 15:39:01 UTC 2016
Thanks for the review, Stefan. I have removed the periods.
Rachel
On 4/6/2016 7:33 AM, Stefan Johansson wrote:
> Hi Rachel,
>
> On 2016-04-05 20:00, Rachel Protacio wrote:
>> Hello,
>>
>> Please review this change, converting -XX:+PrintCompressedOopsMode to
>> -Xlog:gc+heap. The existing diagnostic flag has been aliased to the
>> info level of this tagset (for the "Heap address" message that for
>> example appears in the hs_err file), and there are both debug and
>> trace levels of logging available as well, as per our established
>> schema for assigning levels.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8152896
>> Open webrev: http://cr.openjdk.java.net/~rprotacio/8152896.00/
>>
> The change looks good in general but I see that some log messages have
> a dot in the end. I know you're just moving this over to UL but would
> you mind removing these dots to have the same style as other (gc,
> heap) messages.
>
> Thanks,
> Stefan
>
>> Passes JPRT and RBT quick/non-colo tests.
>>
>> Thanks!
>> Rachel
>
More information about the hotspot-runtime-dev
mailing list