RFR: 8152896: Convert PrintCompressedOopsMode to Unified Logging
Rachel Protacio
rachel.protacio at oracle.com
Wed Apr 6 17:06:53 UTC 2016
Great.
Rachel
On 4/6/2016 12:30 PM, Vladimir Kozlov wrote:
> On 4/6/16 9:29 AM, Vladimir Kozlov wrote:
>> I doubt anyone except using it. Okay, I agree with this change.
>
> except us
>
>>
>> Thanks,
>> Vladimir
>>
>> On 4/6/16 8:58 AM, Rachel Protacio wrote:
>>> Thanks for the review!
>>> There are no appearances of the string "heap address" in any jtreg
>>> tests
>>> or tonga tests. Is there any other place that might check?
>>> Rachel
>>>
>>> On 4/5/2016 2:10 PM, Vladimir Kozlov wrote:
>>>> Looks fine except next change. Do we have a test which parse this
>>>> output?:
>>>>
>>>> ! st->print("heap address: " PTR_FORMAT ", size: " SIZE_FORMAT "
>>>> MB",
>>>> ! st->print("Heap address: " PTR_FORMAT ", size: " SIZE_FORMAT "
>>>> MB",
>>>>
>>>> Thanks,
>>>> Vladimir
>>>>
>>>> On 4/5/16 11:00 AM, Rachel Protacio wrote:
>>>>> Hello,
>>>>>
>>>>> Please review this change, converting -XX:+PrintCompressedOopsMode to
>>>>> -Xlog:gc+heap. The existing diagnostic flag has been aliased to the
>>>>> info
>>>>> level of this tagset (for the "Heap address" message that for example
>>>>> appears in the hs_err file), and there are both debug and trace
>>>>> levels
>>>>> of logging available as well, as per our established schema for
>>>>> assigning levels.
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8152896
>>>>> Open webrev: http://cr.openjdk.java.net/~rprotacio/8152896.00/
>>>>>
>>>>> Passes JPRT and RBT quick/non-colo tests.
>>>>>
>>>>> Thanks!
>>>>> Rachel
>>>
More information about the hotspot-runtime-dev
mailing list