RFR: 8152896: Convert PrintCompressedOopsMode to Unified Logging

[Rachel Protacio]

Hi, Harold,

Thanks for noticing.

The only output UseCompressedOops.java looks for is from the info-level 
logging in universe.cpp. The rest is

    src/share/vm/runtime/arguments.cpp:1902: warning("Max heap size too
    large for Compressed Oops");

So since PrintCompressedOopsMode is aliased to the info level of the 
logging, it still would work as-is ("would" because the test is 
currently @ignore'd).

But in terms of the UnlockDiagnosticVMOptions, that's true that it's not 
needed now for PrintCompressedOopsMode. I'll make sure it'snot needed 
for the other flags and if not, I'll delete it from those two tests.

Rachel

On 4/5/2016 4:19 PM, harold seigel wrote:
> Hi Rachel,
>
> Does hotspot/test/runtime/CompressedOops/UseCompressedOops.java also 
> need to change?
>
>     private static OutputAnalyzer testCompressedOops(ArrayList<String> 
> flags1, String... flags2) throws Exception {
>         ArrayList<String> args = new ArrayList<>();
>
>         // Always run with these three:
>         args.add("-XX:+UnlockDiagnosticVMOptions");
>         args.add("-XX:+PrintCompressedOopsMode");
>
>
> Also, I think -XX:+UnlockDiagnosticVMOptions can be removed from this 
> test and from CompressedClassPointers.java.
>
> Thanks, Harold
>
> On 4/5/2016 2:00 PM, Rachel Protacio wrote:
>> Hello,
>>
>> Please review this change, converting -XX:+PrintCompressedOopsMode to 
>> -Xlog:gc+heap. The existing diagnostic flag has been aliased to the 
>> info level of this tagset (for the "Heap address" message that for 
>> example appears in the hs_err file), and there are both debug and 
>> trace levels of logging available as well, as per our established 
>> schema for assigning levels.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8152896
>> Open webrev: http://cr.openjdk.java.net/~rprotacio/8152896.00/
>>
>> Passes JPRT and RBT quick/non-colo tests.
>>
>> Thanks!
>> Rachel
>