RFR: 8152468: PrintMiscellaneous in constantPool should use classresolve logging.

[Rachel Protacio]

Looks good to me.
Rachel

On 4/7/2016 1:59 PM, Max Ockner wrote:
> New webrev. http://cr.openjdk.java.net/~mockner/8151526.02
> On 4/6/2016 12:46 PM, Coleen Phillimore wrote:
>>
>> Hi Max,  Thanks for doing this.
>>
>> // FIXME: should be an assert
>> *if (PrintMiscellaneous && (Verbose||WizardMode)) {*
>> *tty->print_cr("bad operand %d in:", which); cpool->print();*
>> *}*
>> *+log_trace(classresolve)("bad operand %d in:", which); cpool->print();*
>>
>>
>> Can you make this log_debug() since it seems to be trying to catch a 
>> bug?
>>
> Yes. fixed.
>> For the other two changes, I don't see a ResourceMark.  Can you add 
>> one to both with ResourceMark rm(THREAD);  The THREAD parameter makes 
>> the ResourceMark inexpensive in terms of code generated.
>>
> Yes. fixed.
>> Also I just noticed that trace_class_resolution does a bit of work 
>> even when logging is disabled.  Can you add a
>>    if (log_is_enabled(Debug, classresolve)) {
>> before the trace_class_resolution call?
>>
> Fixed.
>>
>> Lastly, I think we should point out that we agreed that the 
>> classresolve tag is going to become the tag set class,resolve, with 
>> an RFE that you're going to file.
>>
>> Thanks,
>> Coleen
>>
>>
>> On 4/6/16 11:33 AM, Max Ockner wrote:
>>> Hello hello everyone,
>>>
>>> Please review this addition to classresolve logging.
>>>
>>> Bug https://bugs.openjdk.java.net/browse/JDK-8152468
>>> Webrev http://cr.openjdk.java.net/~mockner/8152468.01/
>>>
>>> There were a few bits of classresolve logging that was guarded by 
>>> PrintMiscellaneous instead of TraceClassResolution, and were missed 
>>> in the initial conversion. This has been fixed and the classresolve 
>>> test has been updated to check or new output.
>>>
>>> Tested with jtreg runtime.
>>>
>>> Thanks,
>>> Max
>>>
>>
>>
>