RFR(XS): JDK-8153549 - [TESTBUG] remove obsolete runtime/SharedArchiveFile/BasicJarBuilder

harold seigel harold.seigel at oracle.com
Thu Apr 14 14:29:06 UTC 2016


The change looks good!
Harold

On 4/14/2016 10:26 AM, Mikhailo Seledtsov wrote:
> Ioi, Lois, George,
>
>  Thank you for review.
>
> I believe I still need one Capital "R" reviewer for an open change.
> Any Reviewer volunteers for this simple file removal change? Please 
> take a look.
>
> Thank you,
> Misha
>
>
> On 4/11/2016 7:37 AM, Mikhailo Seledtsov wrote:
>> Please review this simple fix - the deletion of obsolete/redundant 
>> test utility class
>> BasicJarBuilder. The functionality is now inside the 
>> ClassFileInstaller.java, and this
>> utility is redundant. The work here was mainly to make sure no other 
>> parts
>> of jdk or test reference BasicJarBuilder.
>>
>>   JBS: https://bugs.openjdk.java.net/browse/JDK-8153549
>>   Webrev:  http://cr.openjdk.java.net/~mseledtsov/8153549.00/
>>   Testing:
>>     - ensure no-one else uses it: grepped all hs-rt repository - no 
>> references
>>     - removed BasicJarBuilder; ran hotspot_all group locally on 
>> Linux-x64
>>         Pass
>>
>> Thank you,
>> Misha
>>
>



More information about the hotspot-runtime-dev mailing list