RFR: 8154235: Using deprecated flags converted to UL shows wrong hint

Robbin Ehn robbin.ehn at oracle.com
Fri Apr 15 07:10:29 UTC 2016


Thanks Coleen!

/Robbin

On 04/14/2016 08:17 PM, Coleen Phillimore wrote:
> Looks good.
> Coleen
>
> On 4/14/16 8:26 AM, Robbin Ehn wrote:
>> Hi all,
>>
>> Please review.
>>
>> When using a deprecated flag that have been converted to UL,
>> we print the wrong hint when it contains more than one tag.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8154235
>>
>> Thanks!
>>
>> /Robbin
>>
>> diff -r 6acb563d8621 src/share/vm/runtime/arguments.cpp
>> --- a/src/share/vm/runtime/arguments.cpp    Thu Apr 14 08:30:37 2016
>> +0200
>> +++ b/src/share/vm/runtime/arguments.cpp    Thu Apr 14 14:18:30 2016
>> +0200
>> @@ -998,7 +998,7 @@
>>    int max_tags = sizeof(tagSet)/sizeof(tagSet[0]);
>>    for (int i = 0; i < max_tags && tagSet[i] != LogTag::__NO_TAG; i++) {
>>      if (i > 0) {
>> -      strncat(tagset_buffer, ",", max_tagset_len -
>> strlen(tagset_buffer));
>> +      strncat(tagset_buffer, "+", max_tagset_len -
>> strlen(tagset_buffer));
>>      }
>>      strncat(tagset_buffer, LogTag::name(tagSet[i]), max_tagset_len -
>> strlen(tagset_buffer));
>>    }
>


More information about the hotspot-runtime-dev mailing list