RFR(s) 8154457: runtime/SharedArchiveFile/SharedStrings Shared string table stats missing

[Jiangli Zhou]

Hi Lois, Harold, Misha and George,

Thank you for the reviews! I’ve incorporated all of your suggestions.

Thanks!

Jiangli

> On Apr 20, 2016, at 4:51 AM, Lois Foltan <lois.foltan at oracle.com> wrote:
> 
> 
> On 4/19/2016 9:26 PM, Jiangli Zhou wrote:
>> Please review the following change for JDK-8154457 <https://bugs.openjdk.java.net/browse/JDK-8154457>.
>> 
>>   http://cr.openjdk.java.net/~jiangli/8154457/webrev.00/
>> 
>> Added more information when print out message reporting disabling the shared strings at CDS dump time. The shared strings support requires UseG1GC, UseCompressedOops  and UseCompressedClassPointers all to be true. There are cases where the UseCompressedOops and UseCompressedClassPointers options are disabled due to other VM settings. For example, the UseCompressedOops  and UseCompressedClassPointers are turned off if the VM is running in interpreter only mode, or the if MaxHeapSize is too large. The printed message now includes the value of those three options.
>> 
>> Also, handle the cases when shared strings are disabled in SharedStrings.java test.
> 
> Hi Jiangli,
> 
> I think this looks good. One very minor comment:
> 
> src/share/vm/classfile/stringTable.cpp
> "Current setting:" should probably be "Current settings:"
> 
> I don't need to see another webrev.
> 
> Thanks,
> Lois
> 
>> 
>> Thanks,
>> Jiangli
>