RFR(S): 8154996: [aix] Implement compare_file_modified_times for "8146879: Add option ..."
Volker Simonis
volker.simonis at gmail.com
Mon Apr 25 15:29:17 UTC 2016
Hi Goetz,
your change looks good.
I'm only a little confused about the original change for 8146879 where
'compare_file_modified_times()' returns seconds on some platforms and
seconds or nanoseconds on others. It's also not clear if "better than
second" resolution is required (or desired). If that would improve the
functionality we could additionally use the st_mtime_n field on AIX
which provides nanosecond resolution. But as your change is "as good
as" Solaris, I think its OK to push it and do the possible enhancement
in a follow up change.
Regards,
Volker
On Mon, Apr 25, 2016 at 1:03 PM, Lindenmaier, Goetz
<goetz.lindenmaier at sap.com> wrote:
> Hi
>
> I need another fix for AIX to 8146879. This is AIX-only, though:
> http://cr.openjdk.java.net/~goetz/wr16/8154996-aix_compFile/webrev.01/
>
> It simply implements the new OS function. Please review.
>
> Thanks,
> Goetz.
More information about the hotspot-runtime-dev
mailing list