RFR: 8154719: JvmtiBreakpoint rename method print() to print_on()

Staffan Larsen staffan.larsen at oracle.com
Tue Apr 26 08:18:25 UTC 2016


Looks good!

Thanks,
/Staffan

> On 20 apr. 2016, at 13:47, Robbin Ehn <robbin.ehn at oracle.com> wrote:
> 
> Hi all, please review!
> 
> print() method was changed in 8154041 to have outputStream argument, this renames print to print_on.
> Since JvmtiBreakpoint extends GrowableElement print_on already exists as a virtual const method, hence the const changes.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8154719
> Webrev: http://cr.openjdk.java.net/~rehn/8154719/webrev/
> 
> Tested with:
> 
> #define TraceJVMTICalls false
> in hotspot/src/share/vm/prims/jvmtiEnv.cpp
> set to true with test-set nsk.jvmti.SetBreakpoint
> 
> Thanks!
> 
> /Robbin



More information about the hotspot-runtime-dev mailing list