RFR: 8154719: JvmtiBreakpoint rename method print() to print_on()
Coleen Phillimore
coleen.phillimore at oracle.com
Tue Apr 26 14:28:56 UTC 2016
Agree, looks good. Thank you for making this change.
Coleen
On 4/26/16 4:49 AM, Robbin Ehn wrote:
> Hi Serguei,
>
> Thanks!
>
> /Robbin
>
> On 04/26/2016 10:48 AM, serguei.spitsyn at oracle.com wrote:
>> Hi Robin,
>>
>> Looks good.
>>
>> Thanks,
>> Serguei
>>
>>
>> On 4/20/16 04:47, Robbin Ehn wrote:
>>> Hi all, please review!
>>>
>>> print() method was changed in 8154041 to have outputStream argument,
>>> this renames print to print_on.
>>> Since JvmtiBreakpoint extends GrowableElement print_on already exists
>>> as a virtual const method, hence the const changes.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8154719
>>> Webrev: http://cr.openjdk.java.net/~rehn/8154719/webrev/
>>>
>>> Tested with:
>>>
>>> #define TraceJVMTICalls false
>>> in hotspot/src/share/vm/prims/jvmtiEnv.cpp
>>> set to true with test-set nsk.jvmti.SetBreakpoint
>>>
>>> Thanks!
>>>
>>> /Robbin
>>
More information about the hotspot-runtime-dev
mailing list