RFR(xs): 8154976: UseSharedSpaces error message is incomplete

Calvin Cheung calvin.cheung at oracle.com
Wed Apr 27 17:51:49 UTC 2016


Thanks for you quick review, Chris.
Calvin

On 4/27/16, 10:35 AM, Chris Plummer wrote:
> Hi Calvin,
>
> Looks good.
>
> Chris
>
> On 4/27/16 10:18 AM, Calvin Cheung wrote:
>>
>> Please review this small fix for completing the error message in case 
>> there's a mapping failure when using a CDS archive. This error will 
>> be shown when the -XX:+PrintSharedSpaces option is used.
>>
>> Before the fix:
>> UseSharedSpaces: Unable to map %s shared space at required address.
>>
>> After the fix:
>> UseSharedSpaces: Unable to map ReadOnly shared space at required 
>> address.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8154976
>>
>> webrev: http://cr.openjdk.java.net/~ccheung/8154976/webrev.00/
>>
>> Testing:
>>     JPRT
>>     manual test on windows to ensure the error message is correct.
>>
>> thanks,
>> Calvin
>


More information about the hotspot-runtime-dev mailing list