RFR(XS): 8153835: Fix range of flag MaxDirectMemorySize which is parsed at jlong.

Volker Simonis volker.simonis at gmail.com
Thu Apr 28 09:39:37 UTC 2016


Hi Gerard,

the change looks good!

Regards,
Volker


On Mon, Apr 18, 2016 at 4:53 PM, Gerard Ziemski
<gerard.ziemski at oracle.com> wrote:
> Thank you for the review Goetz!
>
> Can I have a second review for this simple fix please?
>
> In this fix we set the max range value to max_jlong (and change the type to uint64_t) since it gets assigned to MaxDirectMemorySize property that is later parsed as “java long” (in java.base/VM.java:290)
>
> https://bugs.openjdk.java.net/browse/JDK-8153835
> http://cr.openjdk.java.net/~gziemski/8153835_rev1/
>
> Passes JPRT hotspot and RBT hotspot/test/runtime/CommandLine/OptionsValidation
>
>
> cheers
>


More information about the hotspot-runtime-dev mailing list