RFR(S) 8030221: Checking for anonymous class should check for NULL as well as potential nesting

harold seigel harold.seigel at oracle.com
Tue Aug 16 15:54:43 UTC 2016


Hi Coleen,

Thanks for the comments.  In a different fix, for bug JDK-8058575 
<https://bugs.openjdk.java.net/browse/JDK-8058575>, I plan to require 
the host class to be an instance class and change the type of 
_host_klass to instanceKlass.

Thanks, Harold


On 8/16/2016 10:48 AM, Coleen Phillimore wrote:
>
> Can host class actually be an array class?
>
> It seems like more error if the host class is a primitive, array, or 
> if it is another anonymous class.
>
> Then you can pass it as InstanceKlass as host_class everwhere and not 
> have these casts.
>
> Coleen
>
> On 8/15/16 3:34 PM, harold seigel wrote:
>> Hi,
>>
>> Please review this fix for JDK-8030221.  The fix makes sure that, if 
>> the specified host class for a VM anonymous is another anonymous 
>> class, that the actual host class is the specified host class's host 
>> class.  For example, if named class N is the host class for anonymous 
>> class A1, and A1 is the specified host class for anonymous class A2, 
>> then the actual host class for A2 will be named class N.
>>
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8030221
>>
>> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8030221/
>>
>> The fix was tested with the JCK Lang and VM tests, the hotpot, and 
>> java/lang, java/util and other JTreg tests, the NSK quick tests, and 
>> with the RBT runtime nightly tests.
>>
>> Thanks, Harold
>



More information about the hotspot-runtime-dev mailing list