RFR: 8158854: Ensure release_store is paired with load_acquire in lock-free code

Aleksey Shipilev aleksey.shipilev at gmail.com
Thu Aug 18 14:15:01 UTC 2016


On 08/18/2016 05:50 AM, David Holmes wrote:
> webrev: http://cr.openjdk.java.net/~dholmes/8158854/webrev/

Looks good to me. Minor nit:

*) inline declarations have different indenting, is that our code style?

370   Klass* array_klasses() const             { return _array_klasses; }
 371     inline Klass* array_klasses_acquire() const; // load with
acquire semantics
 372   void set_array_klasses(Klass* k)         { _array_klasses = k; }
 373     inline void release_set_array_klasses(Klass* k); // store with
release semantics

Thanks,
-Aleksey



More information about the hotspot-runtime-dev mailing list