RFR(S): 8163146 - Remove os::check_heap on Windows

Thomas Stüfe thomas.stuefe at gmail.com
Wed Aug 24 06:32:52 UTC 2016


Hi Christian,

this looks fine.

Out of curiosity, what were the issues? Did you get false positives or did
HeapValidate not find anything?

Kind Regards, Thomas

On Tue, Aug 23, 2016 at 11:54 PM, Christian Tornqvist <
christian.tornqvist at oracle.com> wrote:

> Hi everyone,
>
>
>
> Please review this small change that removes os::check_heap, it's proven to
> be unreliable. The same functionality and more can be enabled in Windows
> using gflags (pageheap) or by turning on heap debugging in Windbg using the
> !heap extension.
>
>
>
> Tested by running hotspot_fast_runtime test group on all platforms.
>
>
>
> Webrev:
>
> http://cr.openjdk.java.net/~ctornqvi/webrev/8163146/webrev.00/
>
>
>
> Bug:
>
> https://bugs.openjdk.java.net/browse/JDK-8163146
>
>
>
> Thanks,
>
> Christian
>
>


More information about the hotspot-runtime-dev mailing list