RFR(S): 8150823: UL disables log outputs incorrectly
Marcus Larsson
marcus.larsson at oracle.com
Thu Aug 25 09:20:08 UTC 2016
Thanks Staffan!
Marcus
On 08/25/2016 11:17 AM, Staffan Larsen wrote:
> Looks good!
>
> Thanks,
> /Staffan
>
>> On 25 aug. 2016, at 10:50, Marcus Larsson <marcus.larsson at oracle.com> wrote:
>>
>> Hi,
>>
>> Please review the following patch to fix a bug in UL where -Xlog:disable would not disable all logging if there are multiple LogFileOutputs configured. The problem is that disable_logging() iterates the list of log outputs from start to end, removing outputs as it goes and thus modifying the list it iterates over. The fix is to let it pop outputs off the end of the list instead.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~mlarsson/8150823/webrev.00/
>>
>> Issue:
>> https://bugs.openjdk.java.net/browse/JDK-8150823
>>
>> Testing:
>> Modifed test through JPRT
>>
>> Thanks,
>> Marcus
More information about the hotspot-runtime-dev
mailing list