RFR(XXS): 8165014: Unaligned unsafe access should throw InternalError on Solaris

[Doerr, Martin]

Hi David,

thank you very much for the review and for sponsoring.

Best regards,
Martin

-----Original Message-----
From: David Holmes [mailto:david.holmes at oracle.com] 
Sent: Mittwoch, 31. August 2016 08:19
To: Doerr, Martin <martin.doerr at sap.com>; hotspot-runtime-dev at openjdk.java.net
Subject: Re: RFR(XXS): 8165014: Unaligned unsafe access should throw InternalError on Solaris

Hi Martin,

On 30/08/2016 8:42 PM, Doerr, Martin wrote:
> Hi,
>
> as discussed in http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-August/020888.html,
> the signal handler on Solaris SPARC should throw a java.lang.InternalError when Unsafe accesses unaligned addresses.
> This is currently broken because the signal handler only accepts BUS_OBJERR which is not sufficient.
>
> Proposed fix:
> http://cr.openjdk.java.net/~mdoerr/8165014_sparcSIGBUS/webrev.00/
>
> Please review. I will also need a sponsor.

I can sponsor this for you.

I was unsure whether we should in fact cater for unaligned accesses, but 
causing InternalError to be thrown instead of crashing is somewhat cleaner.

Reviewed.

Thanks,
David

> Best regards,
> Martin
>
>