RFR(M): JDK-8165496 assert(_exception_caught == false) failed: _exception_caught is out of phase

Dmitry Samersoff dmitry.samersoff at oracle.com
Tue Dec 6 09:49:05 UTC 2016


Coleen,

Thank you for review!

> I assume that you reran the test case for the bug where you added the
> bit in opto/runtime.cpp ?

Yes.

I also verified that we get exactly the same number of jvmti exception
events with and without my changes and with and without
changes for 8134434

-Dmitry

On 2016-12-05 19:01, Coleen Phillimore wrote:
> I think this change looks good and also much cleaner.
> 
> I assume that you reran the test case for the bug where you added the
> bit in opto/runtime.cpp ?
> 
> summary:     8134434: JVM_DoPrivileged() fires assert(_exception_caught
> == false) failed: _exception_caught is out of phase
> 
> thanks,
> Coleen
> 
> 
> On 12/5/16 4:30 AM, Dmitry Samersoff wrote:
>> Everybody,
>>
>> Please review.
>>
>> http://cr.openjdk.java.net/~dsamersoff/JDK-8165496/webrev.07/
>>
>> Bug link:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8165496
>>
>> Two separate flags, exception_detected and exception_caught, replaced
>> with one that changes it's state.
>>
>> Assert assert(_exception_caught == false) and fix for JDK-8134434 are
>> removed.
>>
>> Testing:
>>    1. Manual testing of instrumented hotspot
>>    2. Local ks with stress agent
>>    3. RBT ks with stress agent
>>    4. RBT hotspot_all
>>
>> -Dmitry
>>
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.


More information about the hotspot-runtime-dev mailing list