RFR(S): 8170672: Event-based tracing to support classloader instances

Coleen Phillimore coleen.phillimore at oracle.com
Tue Dec 6 22:29:19 UTC 2016


http://cr.openjdk.java.net/~mgronlun/8170672/webrev01/src/share/vm/trace/traceStream.hpp.udiff.html

If _st is a stream that you've passed in like logStream, I don't think 
you want a ResourceMark because the ResourceMark belongs outside where 
you created the stream.   Otherwise, it could get nested resource mark 
assertions.

This change looks good.  I'm glad you pass the CLD rather than the 
class_loader oop.

thanks,
Coleen


On 12/5/16 6:33 PM, Markus Gronlund wrote:
> Greetings,
>
>   
>
> Kindly asking for reviews for the following changeset:
>
>   
>
> Bug/Enh: https://bugs.openjdk.java.net/browse/JDK-8170672
>
> Webrev: http://cr.openjdk.java.net/~mgronlun/8170672/webrev01/
>
> (this work is covered by an FC exception)
>
>   
>
> Summary:
>
> Event-based tracing previously had little information about class loaders; a class loader was essentially treated no different than from a regular class (type information only).
>
> With JDK9, supported has been added to java.lang.ClassLoader to associate a name with an individual class loader instance.
>
>   
>
> This changeset will allow the name information of individual class loader instances to be provided by the event-based tracing framework.
>
>   
>
> Aux info:
>
> Some folding of the numerous macros completed as well.
>
>   
>
> Thanks in advance
> Markus
>
>   



More information about the hotspot-runtime-dev mailing list