RFR(S): 7034834 JVMTI xml file referring to old JDK version

[Daniel D. Daugherty]

On 12/7/16 12:40 PM, serguei.spitsyn at oracle.com wrote:
> A small update with the Dmitry's suggestions:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/7034834-Doc.hs3/ 
>
>
>   The spaces are added around '--' in 'VM--see'.
>   A real links are added for two more 'JNI Specification' references.

src/share/vm/prims/jvmti.xml
     No comments.

src/share/vm/prims/jvmti.xsl
     Nice solution to the release issue.


>
> The JVM TI spec can be found at:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/7034834-Doc.hs3/jvmti.html 
>
>
>
> Welcome for a sanity check (one would be enough)!

Don't know that I qualify as sane, but these changes look good.

Dan


>
> Thanks,
> Serguei
>
>
> On 12/7/16 09:49, serguei.spitsyn at oracle.com wrote:
>> Dmitry,
>>
>> Thank you a lot for review!
>> I will fix issues pointed below.
>> Nice catch.
>>
>> Thanks,
>> Serguei
>>
>>
>> On 12/7/16 06:41, Dmitry Samersoff wrote:
>>> Serguei,
>>>
>>> Looks good to me.
>>>
>>> PS:
>>>   Could you add spaces around -- in VM--see at l.2112
>>>   Also, Only one mention of JNI Specification of 3 is clickable.
>>>
>>> -Dmitry
>>>
>>>
>>> On 2016-12-06 21:37, serguei.spitsyn at oracle.com wrote:
>>>> Dmitry, David and Coleen,
>>>>
>>>>
>>>> The updated webrev is:
>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/7034834-Doc.hs2/ 
>>>>
>>>>
>>>> The jvmti_html.zip is in the attachement.
>>>>
>>>> The change is that the prefix
>>>> http://docs.oracle.com/javase/<majorversion> is added
>>>> in the <xsl:template match="externallink">.
>>>> This prefix is tripped in the jvmti.xml from all the externallink 
>>>> id's.
>>>>
>>>> Now, the JDK version in the link will be automatically updated with 
>>>> the
>>>> majorversion change.
>>>>
>>>>
>>>> Thanks,
>>>> Serguei
>>>>
>>>>
>>>>
>>>> On 12/5/16 21:30, serguei.spitsyn at oracle.com wrote:
>>>>> Hi Coleen,
>>>>>
>>>>> Thank you for looking at this fix!
>>>>>
>>>>>
>>>>> On 12/5/16 07:41, Coleen Phillimore wrote:
>>>>>> I checked your jdk9 links to see if they correspond to jdk8 links 
>>>>>> and
>>>>>> they all exist for jdk8.
>>>>> Right. I've verified that too.
>>>>>
>>>>>> Is there any way to parameterize this in jvmti.xml?
>>>>> I was already thinking about it and only after your question got an
>>>>> idea. :)
>>>>> Let me check if it can be simple enough in the .xsl implementation.
>>>>>
>>>>>
>>>>>> http://docs.oracle.com/javase/9/docs/technotes/guides
>>>>>>
>>>>>> Otherwise, this looks good.
>>>>> Thanks!
>>>>> Serguei
>>>>>
>>>>>
>>>>>> thanks,
>>>>>> Coleen
>>>>>>
>>>>>>
>>>>>> On 12/3/16 2:01 AM, serguei.spitsyn at oracle.com wrote:
>>>>>>> One more attempt to send this e-mail correctly. :)
>>>>>>>
>>>>>>> Please, review a fix for the bug:
>>>>>>>    https://bugs.openjdk.java.net/browse/JDK-7034834
>>>>>>>
>>>>>>> Webrev:
>>>>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/7034834-Doc.hs1/ 
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Summary:
>>>>>>>
>>>>>>>    The JVM TI spec has links to the old JDK 7 release documents.
>>>>>>>    The fix is to make it up-to-date and link to the JDK 9 docs.
>>>>>>>
>>>>>>>    One issue with the fix that the JDK 9 doc pages do not exist 
>>>>>>> yet.
>>>>>>>    I hope that the JDK 9 release doc pages will be created the 
>>>>>>> same way
>>>>>>>    as they were for JDK 8. The JVM TI spec for JDK 8 has the same
>>>>>>>    problem as it also has links to the JDK 7 release documents.
>>>>>>>    I'd like to fix this issue in the JDK 9 ASAP in order to be able
>>>>>>>    to backport the fix to JDK 8.
>>>>>>>
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Serguei
>>>>>>>
>>>
>>
>