RFR: 8170821: Ensure access checks result in consistent answers

Rachel Protacio rachel.protacio at oracle.com
Fri Dec 9 18:07:42 UTC 2016


Thank for the reviews, Lois and Harold!

Rachel


On 12/9/2016 11:29 AM, Lois Foltan wrote:
>
> On 12/9/2016 10:13 AM, Rachel Protacio wrote:
>> Thanks, Harold -
>>
>> New webrev: http://cr.openjdk.java.net/~rprotacio/8170821.01/
>
> Looks good Rachel!  Thank you for adding this test.
> Lois
>
>>
>>
>> On 12/9/2016 9:09 AM, harold seigel wrote:
>>> Hi Rachel,
>>>
>>> The test looks good, lots of good comments.  Just a couple of 
>>> questions.
>>>
>>> 1. Does the test need to be run with -Xlog:modules=debug ?
>> No, not really. It was there because it was helpful in the case that 
>> the test fails, but you're right, it's extra effort/output now. I've 
>> removed it.
>>>
>>> 2. Is -Xbootclasspath/a:. needed ?
>> Nope, deleted that too.
>> Thanks!
>> Rachel
>>>
>>> Thanks, Harold
>>>
>>>
>>> On 12/8/2016 4:18 PM, Rachel Protacio wrote:
>>>> Hello!
>>>>
>>>> Please review this change adding a jtreg test to ensure that access 
>>>> check results are cached, so the same check produces the same 
>>>> answer even if the user adds access in between. (Credit to Lois for 
>>>> the actual workings of the test.)
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8170821
>>>> Open webrev: http://cr.openjdk.java.net/~rprotacio/8170821.00/
>>>>
>>>> Passes JPRT on all platforms.
>>>>
>>>> Thanks,
>>>> Rachel
>>>>
>>>
>>
>



More information about the hotspot-runtime-dev mailing list