RFR(XS) [aarch64] hs_err logs do not print register mappings

Andrew Dinn adinn at redhat.com
Wed Dec 14 12:46:38 UTC 2016


On 14/12/16 05:33, David Holmes wrote:
> On 14/12/2016 3:27 AM, White, Derek wrote:
>> Please review this simple change to have the hs_err logs print
>> register mappings on aarch64 as they are on other platforms. See end
>> of message for example.
>>
>> BUG: https://bugs.openjdk.java.net/browse/JDK-8171129
>>
>> WEBREV: http://cr.openjdk.java.net/~drwhite/8171129/webrev.01/
> 
> Looks okay, but what about the BUILTIN_SIM case?

The code included via BUILTIN_SIM was only ever relevant to JDK8. We
used the BUILTIN_SIM paths to bootstrap the AArch64 code on x86 (it
makes the JVM jump into an AArch64 simulator whenever it enters JITted
AArch64 code and back again when it calls out to non-JITted code :-).

The BUILTIN_SIM code no longer works in JDK8. It was upstreamed into
JDK9 wholesale along with all other changes ti support AArch64. However,
the upstreamed BUILTIN_SIM code never worked in JDK9. A separate JIRA to
address its removal from both JDK8 and JDK9 code bases might be worth
raising but that problem should not be allowed to hinder this fix.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander


More information about the hotspot-runtime-dev mailing list