RFR(xs): 8171011: convert some CDS dump time warning and error messages to informational messages which will be printed with -XX:+PrintSharedSpaces

Jiangli Zhou jiangli.zhou at Oracle.COM
Mon Dec 19 23:06:00 UTC 2016


Hi Calvin,

The comment at line 1330 also needs to be updated as the use of —limit-modules is no longer fatal with your change. Thanks for making the changes.

1330                                         "--limit-modules", // cannot use at dump time

Thanks,
Jiangli

> On Dec 19, 2016, at 2:51 PM, Calvin Cheung <calvin.cheung at oracle.com> wrote:
> 
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8171011
> 
> Please review this small change for the above bug.
> 
> Example output from the following command line:
> $MYJDK/bin/java --limit-modules mymod -Xshare:dump -XX:+PrintSharedSpaces
> 
> before change:
> Error occurred during initialization of VM
> Cannot use the following option when dumping the shared archive: --limit-modules
> 
> after change:
> Info: the --limit-modules option is ignored when dumping the shared archive
> Allocated shared space: 50577408 bytes at 0x0000000800000000
> Loading classes to share ...
> 
> webev: http://cr.openjdk.java.net/~ccheung/8171011/webrev.00/
> 
> Testing:
>    JPRT
>    Tests under hotspot/test/runtime/SharedArchiveFile on supported platforms.
> 
> thanks,
> Calvin



More information about the hotspot-runtime-dev mailing list