RFR(S): 8171848: ObjectMonitor verify() and print() methods are empty

Kirill Zhaldybin kirill.zhaldybin at oracle.com
Wed Dec 21 13:24:55 UTC 2016


Thank you for review!

On 21.12.2016 15:46, David Holmes wrote:
> Hi Kirill,
> This cleanup is considered an enhancement and as such is no longer 
> acceptable in JDK 9 - sorry. The CR has been re-targetted to JDK 10.
> The removal itself seems okay. I wonder whether 
> ObjectSynchronizer::verify is itself ever called?
I did not find any calls to it but it was after I sent WebRev.
I will double-check and will send new one if we can just delete 

Regards, Kirill
> David
> On 21/12/2016 8:36 PM, Kirill Zhaldybin wrote:
>> Dear all,
>> Could you please review this fix for 8171848?
>> I deleted both methods from ObjectMonitor and the code which was not
>> doing anything from ObjectSynchronizer::verify().
>> I did local and rbt testing to be sure that I found all calls to deleted
>> methods.
>> WebRev: 
>> http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8171848/webrev.00/
>> CR: https://bugs.openjdk.java.net/browse/JDK-8171848
>> Thank you.
>> Regards, Kirill

More information about the hotspot-runtime-dev mailing list