RFR(S): 8171924: Use SIZE_FORMAT to print size_t values.

David Holmes david.holmes at oracle.com
Fri Dec 23 01:17:06 UTC 2016


Hi Arno,

On 23/12/2016 2:08 AM, Zeller, Arno wrote:
> Hi,
>
> can you please review this change? And I need a sponsor too.
>
> Webrev:
> http://cr.openjdk.java.net/~goetz/wr16/8171924-size_t/webrev.01/

  src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c

There is no SIZE_FORMAT defined when compiling this file. As this is a 
linux specific file and only compiled by compilers that support %z, it 
should remain %z.

---

src/share/vm/gc/g1/g1BiasedArray.hpp

Please update copyright year.

---

Otherwise this seems a reasonable cleanup. The question is whether this 
is really a P3 bug and so can go in after RDP1 has started? Does this 
actually cause build issues on some of your platforms?

If/when this goes ahead I can sponsor it for you.

Thanks,
David

> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8171924
>
> Best regards,
> Arno
>
>


More information about the hotspot-runtime-dev mailing list