RFR(xs): 8149096: Remove unused code in methodComparator

Thomas Stüfe thomas.stuefe at gmail.com
Mon Feb 8 16:11:13 UTC 2016


Thank you, Coleen!
On Feb 8, 2016 16:58, "Coleen Phillimore" <coleen.phillimore at oracle.com>
wrote:

>
> This looks good.  I will sponsor it.  I also looked at this briefly and
> can't see why we'd want this code.
> Thanks,
> Coleen
>
> On 2/8/16 9:24 AM, Thomas Stüfe wrote:
>
>> Hi all,
>>
>> please review and sponsor this little change. It gets rid of two unused
>> methods in methodComparator(cpp/hpp).
>>
>> We stumbled over this because of warings about unchecked realloc() return
>> values; but instead of fixing the code, we may just remove the offending
>> methods, because they are not used anywhere.
>>
>> See also mail thread here:
>>
>> http://openjdk.5641.n7.nabble.com/Unused-code-in-prims-methodComparator-td254425.html
>> .
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8149096
>>
>> webrev:
>>
>> http://cr.openjdk.java.net/~stuefe/webrevs/8149096-remove-unused-code-methodComparator/webrev.00/webrev/
>>
>> Kind Regards, Thomas
>>
>
>


More information about the hotspot-runtime-dev mailing list