RFR: 8149743: JVM crash after debugger hotswap with lambdas

Daniel D. Daugherty daniel.daugherty at oracle.com
Tue Feb 23 14:11:12 UTC 2016


On 2/18/16 9:11 AM, Andreas Eriksson wrote:
> Hi,
>
> Please review this fix for JDK-8149743: JVM crash after debugger 
> hotswap with lambdas
> https://bugs.openjdk.java.net/browse/JDK-8149743
>
> Webrev: http://cr.openjdk.java.net/~aeriksso/8149743/webrev.00/

hotspot/src/share/vm/prims/jvmtiRedefineClasses.cpp
     No comments other than please update the copyright before you push.


jdk/test/com/sun/jdi/RedefineAddPrivateMethod.sh
     L76: debuggeeFailIfPresent "Internal exception:"

     Is the failure mode for this bug always a crash? If so, then
     the above check should work as long as we don't change the
     "Internal exception:" part of the output. If we do that then
     we'll have to update a number of tests... :-)


Thumbs up.

Dan


>
> When redefining a class to add or delete methods an array that's 
> tracking method ordering is not updated correctly.
> This change swaps the method ordering array between the old class 
> being redefined and the scratch class it is being redefined into at 
> the same point where we swap the methods and constant pool between them.
>
> Regards,
> Andreas
>



More information about the hotspot-runtime-dev mailing list