RFR: JDK-8150002 - Check for the validity of oop before printing it in verify_remembered_set

[Daniel D. Daugherty]

On 2/25/16 8:09 AM, Daniel D. Daugherty wrote:
> On 2/25/16 2:13 AM, Shafi Ahmad wrote:
>> Hi All,
>>
>>
>> Please review the trivial change of adding check if object is an oop.
>>
>>
>> Summary: Code change to protect against the crashes that can occur if 
>> the object (obj) in the 'to' region which is being printed here has 
>> been overwritten and is no longer a valid oop.
>>
>>
>> Open webrev: http://cr.openjdk.java.net/~rpatil/8150002/webrev.00/
>
> src/share/vm/gc/g1/heapRegion.cpp
>     No comments.
>
> Thumbs up, but I'm not sure why this RFR went to Runtime since
> this is a GC bug and a fix to GC code.

Forgot to mention that I concur that this is a trivial change so
the HotSpot "trivial change review" rules apply. You can push this
changeset with a single (R)eviewer and without waiting for 24 hours.

Dan


>
> Dan
>
>
>
>>
>> Bug link: https://bugs.openjdk.java.net/browse/JDK-8150002
>>
>>
>> Testing:  JPRT
>>
>>
>> Since this is a trivial change so I haven't run the jtreg tests.
>>
>>
>> Regards,
>>
>> Shafi
>