(S) RFR: 8077648: ARM: BREAKPOINT is wrong for thumb

[David Holmes]

On 12/01/2016 3:31 PM, Dean Long wrote:
> How about moving it to "globalDefinitions_arm.hpp"?  You would just need
> to do #undef BREAKPOINT first.

It would also need, technically, to be conditional upon using gcc.

I also don't know if the aarch32 port would be using this. ??

Thanks,
David

> dl
>
> On 1/11/2016 7:16 PM, David Holmes wrote:
>> Bug is non-public:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8077648
>>
>> In globalDefinitions_gcc.hpp we do
>>
>> #ifdef ARM32
>> #ifdef SOLARIS
>> #define BREAKPOINT __asm__ volatile (".long 0xe1200070")
>> #else
>> #define BREAKPOINT __asm__ volatile (".long 0xe7f001f0")
>> #endif
>> #else
>>
>> The SOLARIS part of this is puzzling to say the least and is being
>> deleted. :)
>>
>> Otherwise the value used in not correct if compiling for Thumb
>> instruction set.
>>
>> Solution is to just use:
>>
>> #define BREAKPOINT __asm__ volatile ("bkpt")
>>
>> webrev: http://cr.openjdk.java.net/~dholmes/8077648/webrev/
>>
>> Thanks,
>> David
>