RFR: 8146435: [TESTBUG] Logging tests are failing intermittently on windows when executed by JPRT

Jiangli Zhou jiangli.zhou at oracle.com
Tue Jan 12 18:42:09 UTC 2016


Hi Rachel,

Looks good. It would be also good to add comments in the tests explaining why they should be run with -Xshare:off.

Thanks,
Jiangli

> On Jan 12, 2016, at 10:27 AM, Rachel Protacio <rachel.protacio at oracle.com> wrote:
> 
> Hello!
> 
> Please review this fix which adds "-Xshare:off" to all UL tests' ProcessBuilders to prevent windows failures. Extreme thanks to Ioi for debugging and finding the source of the problem.
> 
> Open webrev: http://cr.openjdk.java.net/~rprotacio/8146435/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8146435
> 
> Tests sent to JPRT, pass on all platforms.
> 
> Thank you!
> Rachel



More information about the hotspot-runtime-dev mailing list