RFR: 8146435: [TESTBUG] Logging tests are failing intermittently on windows when executed by JPRT
Rachel Protacio
rachel.protacio at oracle.com
Tue Jan 12 20:08:18 UTC 2016
Great, thanks for the review!
Rachel
On 1/12/2016 3:07 PM, Jiangli Zhou wrote:
>> On Jan 12, 2016, at 11:53 AM, Rachel Protacio <rachel.protacio at oracle.com> wrote:
>>
>> Hi,
>>
>> Thanks! Is this http://cr.openjdk.java.net/~rprotacio/8146435.01/ what you had in mind?
> Looks good.
>
> Thanks!
>
> Jiangli
>
>> Rachel
>>
>> On 1/12/2016 1:42 PM, Jiangli Zhou wrote:
>>> Hi Rachel,
>>>
>>> Looks good. It would be also good to add comments in the tests explaining why they should be run with -Xshare:off.
>>>
>>> Thanks,
>>> Jiangli
>>>
>>>> On Jan 12, 2016, at 10:27 AM, Rachel Protacio <rachel.protacio at oracle.com> wrote:
>>>>
>>>> Hello!
>>>>
>>>> Please review this fix which adds "-Xshare:off" to all UL tests' ProcessBuilders to prevent windows failures. Extreme thanks to Ioi for debugging and finding the source of the problem.
>>>>
>>>> Open webrev: http://cr.openjdk.java.net/~rprotacio/8146435/
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8146435
>>>>
>>>> Tests sent to JPRT, pass on all platforms.
>>>>
>>>> Thank you!
>>>> Rachel
More information about the hotspot-runtime-dev
mailing list