RFR: 8146800: Reorganize logging alias code.

[Marcus Larsson]

Hi,

On 01/13/2016 03:49 AM, David Holmes wrote:
> Hi Max,
>
> On 13/01/2016 6:40 AM, harold seigel wrote:
>> Hi Max,
>>
>> Other than the copyright dates and minor #include alphabetizing the
>> changes look good.
>
> I agree with Harold.

+1

Thanks,
Marcus

>
> Thanks,
> David
>
>> Harold
>>
>> On 1/12/2016 3:29 PM, Max Ockner wrote:
>>> David,
>>> Originally, VAR_LOG_TAGS was included to help use the configure_stdout
>>> function. Marcus has suggested that I don't need it so I have 
>>> removed it.
>>> New webrev: http://cr.openjdk.java.net/~mockner/aliastable.04/
>>> Thanks,
>>> Max
>>> On 1/12/2016 1:31 AM, David Holmes wrote:
>>>> Hi Max,
>>>>
>>>> On 12/01/2016 3:02 AM, Max Ockner wrote:
>>>>> Hello all,
>>>>> Please review my fix which reorganizes the alias table for Unified
>>>>> Logging.
>>>>>
>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8146800
>>>>> webrev: http://cr.openjdk.java.net/~mockner/aliastable.03/
>>>>
>>>> Is this supposed to contain the VAR_LOG_TAGS changes?
>>>>
>>>> Is the "deprecation" of the converted tracing flags still to be added?
>>>>
>>>> Otherwise seems okay.
>>>>
>>>> Thanks,
>>>> David
>>>>
>>>>> Summary:
>>>>> How logging aliases used to handled - At the beginning of
>>>>> parse_each_vm_init_arg() in arguments.cpp, each "-XX" argument 
>>>>> would be
>>>>> looked up in the logging alias table to see if there was a match. 
>>>>> If a
>>>>> match was found, then the entire argument would be replaced by a
>>>>> corresponding unified logging argument. This argument would then
>>>>> cascade
>>>>> through the giant case structure until it was caught and handled 
>>>>> close
>>>>> to the bottom of parse_each_vm_init_arg (which happens hundreds of
>>>>> lines
>>>>> later).
>>>>>
>>>>> There is a section of code that handles aliases and deprecation 
>>>>> for -XX
>>>>> options already. After this fix, logging aliases will be handled here
>>>>> instead of substituting entire logging expressions at the 
>>>>> beginning of
>>>>> parse_each_vm_init_arg.
>>>>>
>>>>> Tested with jtreg runtime tests. This includes several logging tests
>>>>> for
>>>>> recently aliased flags.
>>>>>
>>>>> Thanks,
>>>>> Max
>>>>>
>>>
>>