RFR(xs): 8147510: [windows] no text locations shown for register info in hs-err file
Thomas Stüfe
thomas.stuefe at gmail.com
Wed Jan 20 07:53:30 UTC 2016
May I please have a review and a sponsor?
Thank you!
On Sat, Jan 16, 2016 at 10:42 AM, Thomas Stüfe <thomas.stuefe at gmail.com>
wrote:
> Hi,
>
> could I please have reviews and a sponsor for this small fix:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8147510
> Webrev:
> http://cr.openjdk.java.net/~stuefe/webrevs/8147510-windows-register-info-print-location/webrev.00/
>
> When we print register to memory info in hs-err file, text addresses are
> not resolved on windows like on other platforms:
>
> "RCX=0x000000005efa0000 is an unknown value"
>
> This fix changes this (the same way it is implemented on other platforms):
>
> "RCX=C:\d031900\openjdk\jdk9-hs-rt\output\images\jdk\bin\server\jvm.dll +
> 0"
>
> Please note that this printout and the code behind it could be improved
> and cleaned up a lot. For instance, I know that using an on-stack buffer in
> os::find() is not the best implementation here. But I wanted a minimal
> change. For the follow-up work, I opened a new bug:
> https://bugs.openjdk.java.net/browse/JDK-8147512.
>
> Thanks & Regards, Thomas
>
>
>
>
More information about the hotspot-runtime-dev
mailing list