RFR(XS): 8146187: Print develop and nonproduct flags by -XX:+PrintFlags* options in debug build

[Dmitry Dmitriev]

Hi Gerard,

Thank you for looking into that. Please see my comments inline.

Dmitry

On 28.01.2016 20:49, Gerard Ziemski wrote:
> Resending referencing the correct issue:
>
> hi Dmitry,
>
>
> ----
> src/share/vm/runtime/globals.cpp
>
> No comments except that this was easy ;-) And thank you for getting rid of extraneous “printRanges” check.
You are welcome :)
>
> ---
> test/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java
>
> So we are not going to test the debug (non-product) flags at all, even on the debug build? (requires too much time?)
Yes, from my point of view this is not needed. These flags are used for 
development and are constant in product build. I think that these flags 
can increase testing time due it's development nature.

Dmitry
>
>
>> On Jan 28, 2016, at 5:07 AM, Dmitry Dmitriev <dmitry.dmitriev at oracle.com> wrote:
>>
>> Hello,
>>
>> Can I get review for that small patch please?
>>
>> Thanks,
>> Dmitry
>>
>> On 19.01.2016 14:32, Dmitry Dmitriev wrote:
>>> Hello,
>>>
>>> Please review small fix for printing flags functionality. This fix return ability to print develop and not product flags in debug VM by -XX:+PrintFlags* options.
>>> Few comments:
>>> 1) "if (printRanges) {" on line 407 in globals.cpp was deleted, because it located in else branch of "if (!printRanges) {" and therefore always true.
>>> 2) TestOptionsWithRanges.java was corrected to not pick develop and not product flags.
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8146187
>>> webrev.00: http://cr.openjdk.java.net/~ddmitriev/8146187/webrev.00/ <http://cr.openjdk.java.net/%7Eddmitriev/8146187/webrev.00/>
>>> Testing: JPRT, hotspot_all, vm.quick
>>>
>>> Thanks,
>>> Dmitry