RFR(S), URG: JDK-8159925 sun/tools/jps/TestJpsJar.java still fails after fix for JDK-8153278

[Daniel D. Daugherty]

On 7/6/16 2:56 AM, Dmitry Samersoff wrote:
> Everybody,
>
> Please review the fix.
>
>   http://cr.openjdk.java.net/~dsamersoff/JDK-8159925/webrev.01/

test/sun/tools/jps/JpsBase.java
     L64         if (!fullProcessName.startsWith(userDir)) {
     L65             System.err.printf("Test skipped. user.dir '%s' 
doesn't match '%s'\n", userDir, fullProcessName);
         Since you're using startsWith(), the error message should
         be changed like this:

         cur: "doesn't match"
         new: "is not a prefix of"

     L98:                     // Skip the test if user.dir doesn't match 
current path
         Please change "doesn't match" -> "is not a prefix of the"

     L99:                     // It's possible if the test run from 
symlinked dir or windows alias drive
         Typo: "test run" -> "test is run"

test/sun/tools/jps/TestJpsJar.java
     No comments.

Thumbs up modulo the comment corrections.
No need to see a new webrev for those fixes.

Please update copyright years before pushing.

Dan


>
> -Dmitry
>
> -------- Forwarded Message --------
> Subject: RFR(S): JDK-8159925 sun/tools/jps/TestJpsJar.java still fails
> after fix for JDK-8153278
> Date: Wed, 29 Jun 2016 19:12:25 +0300
> From: Dmitry Samersoff <dmitry.samersoff at oracle.com>
> To: serviceability-dev at openjdk.java.net
> <serviceability-dev at openjdk.java.net>
>
> Everybody,
>
> Please review the fix:
>
>    http://cr.openjdk.java.net/~dsamersoff/JDK-8159925/webrev.01/
>
> The problem:
>
>    If you run the test from symlinked location user.dir and the output of
> jps -l may not match to the value returned by File.getAbsolutePath() for
> the same jar file.
>
> Solution:
>
>    Skip the test if user.dir doesn't match File.getAbsolutePath()
>
> -Dmitry
>
>