RFR(S), URG: JDK-8159925 sun/tools/jps/TestJpsJar.java still fails after fix for JDK-8153278

Dmitry Samersoff dmitry.samersoff at oracle.com
Wed Jul 6 20:12:35 UTC 2016


Serguei,

> Should the fix cover other test flags: m, v or V ?
> Otherwise, it looks good, modulo the comments from Dan.

Probably yes, but it's out of scope of this changes.

Thank you for the review!

-Dmitry


On 2016-07-06 22:35, serguei.spitsyn at oracle.com wrote:
> Hi Dmitry,
> 
> Should the fix cover other test flags: m, v or V ?
> Otherwise, it looks good, modulo the comments from Dan.
> 
> Thanks,
> Serguei
> 
> 
> On 7/6/16 01:56, Dmitry Samersoff wrote:
>> Everybody,
>>
>> Please review the fix.
>>
>>   http://cr.openjdk.java.net/~dsamersoff/JDK-8159925/webrev.01/
>>
>> -Dmitry
>>
>> -------- Forwarded Message --------
>> Subject: RFR(S): JDK-8159925 sun/tools/jps/TestJpsJar.java still fails
>> after fix for JDK-8153278
>> Date: Wed, 29 Jun 2016 19:12:25 +0300
>> From: Dmitry Samersoff <dmitry.samersoff at oracle.com>
>> To: serviceability-dev at openjdk.java.net
>> <serviceability-dev at openjdk.java.net>
>>
>> Everybody,
>>
>> Please review the fix:
>>
>>    http://cr.openjdk.java.net/~dsamersoff/JDK-8159925/webrev.01/
>>
>> The problem:
>>
>>    If you run the test from symlinked location user.dir and the output of
>> jps -l may not match to the value returned by File.getAbsolutePath() for
>> the same jar file.
>>
>> Solution:
>>
>>    Skip the test if user.dir doesn't match File.getAbsolutePath()
>>
>> -Dmitry
>>
>>
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.


More information about the hotspot-runtime-dev mailing list