RFR: JDK-8160997 Solaris: deprecated <pwd.h> and <gid.h> interfaces should be replaced

[Alan Burlison]

On 11/07/2016 17:41, Volker Simonis wrote:

> you write that "for Solaris 11, _POSIX_PTHREAD_SEMANTICS enables the
> 'official' POSIX" semantics. Is this strictly true only for Solaris 11
> or also for Solaris 10 already. I know this question is not directly
> related to your change which only applies to jdk9, but we may have to
> downport this change to older Solaris releases so if you have any
> experience with _POSIX_PTHREAD_SEMANTICS on Solaris 10 it would be
> good to know.

It is true for Solaris 10 and even Solaris 9.

> Besides that, could you please also fix the following bits:
>
> hotspot/src/os/solaris/vm/perfMemory_solaris.cpp
>   - why do we need:
>
> +#if defined(SOLARIS)
>
> here. I think this file is always compiled with -DSOLARIS

I was just being (over) cautious, I'll make the change you suggest, thanks.

> jdk/src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c
> jdk/src/jdk.security.auth/solaris/native/libjaas/Solaris.c
> jdk/src/jdk.security.auth/unix/native/libjaas/Unix.c
> - can you please use:
> #if defined(__solaris__)
> (as you did in ProcessHandleImpl_unix.c) instead of:
> #if defined(SOLARIS)

Sure.

> In hotspot code it is more common to use our own platform defines from
> the command line whereas in the jdk repository we usually use the
> defualt system defines for the various platforms.

Ah right, I've seen a mix of styles and hadn't yet figured out the rule 
for which to use where, thanks for the guidance :-)

-- 
Alan Burlison
--