RFR: JDK-8160997 Solaris: deprecated <pwd.h> and <gid.h> interfaces should be replaced
David Holmes
david.holmes at oracle.com
Thu Jul 14 01:20:59 UTC 2016
Hi Alan,
Thanks for noticing this and cleaning it up.
On 14/07/2016 2:50 AM, Alan Burlison wrote:
> On 11/07/2016 14:22, Alan Burlison wrote:
>
>> Hi, I'd like to ask for reviews for:
>>
>> JDK-8160997 Solaris: deprecated <pwd.h> and <gid.h> interfaces should be
>> replaced
>
> I've addressed all the review comments, the updated webrev is available at:
>
> http://cr.openjdk.java.net/~dcubed/for_alanbur/8160997-webrev/1-jdk9-hs-all/
One query: if pwd.h is not the last file included don't we need to undef
_POSIX_PTHREAD_SEMANTICS again to ensure no other included definitions
are affected? If we don't need to do that then I wonder whether
_POSIX_PTHREAD_SEMANTICS should not simply be set via the build system
for all compilations?
Thanks,
David
>
> Thanks,
>
More information about the hotspot-runtime-dev
mailing list