RFR(L): 8161259: Simplify including platform files.

[Lindenmaier, Goetz]

Hmm, how do you define CONCAT? I guess that's the tricky part.

Best regards,
  Goetz.

> -----Original Message-----
> From: Andrew Haley [mailto:aph at redhat.com]
> Sent: Donnerstag, 14. Juli 2016 11:54
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-compiler-
> dev at openjdk.java.net
> Subject: Re: RFR(L): 8161259: Simplify including platform files.
> 
> Hi,
> 
> On 14/07/16 10:17, Lindenmaier, Goetz wrote:
> 
> >> Are we really happy with
> >>   40 #define SUB(x) x
> >>
> >> SUB is a very generic name, and this is some very weird macro hacking.
> >> At least we need an explanation in a comment.
> >
> > That's a good point, I'll rename it to HSSUB (hotspot submacro).
> > It should not be too long because it's used so often on one line.
> 
> How about
> 
>  480 #  define xos_cpu_header(x, y)
> XSTR(SUB(x)SUB(_)SUB(INCLUDE_SUFFIX_OS)SUB(_sparc)SUB(y))
> 
> -->
> 
>  480 #  define xos_cpu_header(x, y)
> XSTR(CONCAT(x,_)CONCAT(INCLUDE_SUFFIX_OS,CONCAT(_sparc,y)))
> 
> or maybe even
> 
>  480 #  define xos_cpu_header(x, y)
> CONCAT5(x,_,INCLUDE_SUFFIX_OS,_sparc,y)
> 
> I would have understood immediately what that was doing.
> 
> Andrew.