RFR: JDK-8160997 Solaris: deprecated <pwd.h> and <gid.h> interfaces should be replaced
Alan Burlison
Alan.Burlison at oracle.com
Thu Jul 14 16:52:15 UTC 2016
On 14/07/2016 17:44, Daniel D. Daugherty wrote:
> The #undef line makes it clear that you wanted the define for
> pwd.h and only pwd.h. To me that's more clear, but I'm not
> going to insist.
>
> I'll leave it up to you and David H. to work out.
>
> Full disclosure: the sooner this review gets wrapped up, the
> sooner I can push the bits since I'm the sponsor. :-)
I think the unguarded #define/#undef is fine if you want to avoid
clutter but I don't have any strong opinion, as long as the macro is
defined before the pwd.g or grp.h files are included it will do the job.
--
Alan Burlison
--
More information about the hotspot-runtime-dev
mailing list