RFR: 8140723: Remove source code conditionalized on JAVASE_EMBEDDED
David Holmes
david.holmes at oracle.com
Fri Jul 15 05:06:47 UTC 2016
On 15/07/2016 8:39 AM, Christian Thalinger wrote:
>
>> On Jul 13, 2016, at 6:26 PM, David Holmes <david.holmes at oracle.com
>> <mailto:david.holmes at oracle.com>> wrote:
>>
>> The bug report for this is confidential but quite simply all of the
>> little tweaks and knobs we added to the open build and source files to
>> support the Java SE Embedded product no longer need to be there for
>> JDK 9. A lot of this has already been addressed in relation to other
>> changes (eg. new hotspot build), but this cleans out the rest.
>>
>> webrev: http://cr.openjdk.java.net/~dholmes/8140723/webrev.hotspot/
>
>
> src/share/vm/runtime/globals.hpp
>
> + range(0, max_jint) \
>
>
> Should be indented, I think.
Fixed - webrev updated in place.
> Otherwise this looks good and I’m glad it’s gone.
Thanks for the review Christian!
David
-----
>>
>> There are related JDK changes being handled in a separate review
>> thread. If you like you can see them all:
>>
>> http://cr.openjdk.java.net/~dholmes/8140723/
>>
>> Thanks,
>> David
>
More information about the hotspot-runtime-dev
mailing list