RFR: 8140723: Remove source code conditionalized on JAVASE_EMBEDDED

[David Holmes]

Hi Chris,

Thanks for the review.

On 19/07/2016 6:41 AM, Chris Plummer wrote:
> Hi David,
>
> webrev.hotspot/src/cpu/x86/vm/globalDefinitions_x86.hpp:
>
> I'm curious as to why the JAVASE_EMBEDDED reference was ever there, but
> your fix seems correct.

It was done in 8077618. Can't recall exact reasoning.

>
> webrev.jdk/make/lib/Awt2dLibraries.gmk:
>
> I know this is really for the JDK review thread, but I'm not on it so
> I'll just ask here. Any reason you didn't just remove the
> BUILD_LIBAWT_XAWT_XToolkit.c_CFLAGS code instead of commenting it out as
> you did?

It will be deleted if the AWT team agree. I called that out explicitly 
on the JDK/AWT review thread.

Thanks,
David

> thanks,
>
> Chris
>
> On 7/13/16 9:26 PM, David Holmes wrote:
>> The bug report for this is confidential but quite simply all of the
>> little tweaks and knobs we added to the open build and source files to
>> support the Java SE Embedded product no longer need to be there for
>> JDK 9. A lot of this has already been addressed in relation to other
>> changes (eg. new hotspot build), but this cleans out the rest.
>>
>> webrev: http://cr.openjdk.java.net/~dholmes/8140723/webrev.hotspot/
>>
>> There are related JDK changes being handled in a separate review
>> thread. If you like you can see them all:
>>
>> http://cr.openjdk.java.net/~dholmes/8140723/
>>
>> Thanks,
>> David
>
>