RFR: JDK-8161601 Solaris: __USE_LEGACY_PROTOTYPES__ is redundant and should be removed

[Gerald Thornbrugh]

Hi Dan and Alan,

Yes, I added the “__USE_LEGACY_PROTOTYPE__” statements as part of a change when the Solaris supported
build platform was something like S10u6.

These changes look good to me.

Thanks!

Jerry
> On Jul 21, 2016, at 10:02 AM, Daniel D. Daugherty <daniel.daugherty at oracle.com> wrote:
> 
> Adding Jerry T explicitly to this review thread...
> 
> On 7/21/16 6:27 AM, Alan Burlison wrote:
>> David Holmes pointed out to me that there were instances of __USE_LEGACY_PROTOTYPES__ in Solaris-related code that were redundant, this patch removes them.
>> 
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8161601
>> 
>> Webrev:
>> http://sthjprt.uk.oracle.com/archives/2016/07
>> 
>> All JPRT tests were successful.
>> 
> 
> > http://cr.openjdk.java.net/~alanbur/JDK-8161601
> 
> General comment
> 
> Please update copyright years as appropriate.
> 
> 
> hotspot/src/os/solaris/vm/jvm_solaris.h
>    No comments.
> 
> hotspot/src/os/solaris/vm/perfMemory_solaris.cpp
>    No comments.
> 
> hotspot/src/share/vm/utilities/globalDefinitions_sparcWorks.hpp
>    Interesting removal of <dirent.h>; reducing the scope of places
>    that get this include? (good idea)
> 
> hotspot/src/closed/os/solaris/vm/os_perf_solaris.cpp
>    No comments.
> 
> Thumbs up.
> 
> I believe the __USE_LEGACY_PROTOTYPES__ uses around <dirent.h>
> were added by Jerry Thornbrugh when our official build platform
> was Solaris 10u6 or something like that.
> 
> Dan
> 
> P.S.
> Alan, I'll setup a repo for pushing this changeset when you
> get through the review process.