RFR 8161696 [TESTBUG] runtime/StackGuardPages/testme.sh uses invalid argument -Xss328k

[Daniel D. Daugherty]

On 7/26/16 10:06 AM, Gerald Thornbrugh wrote:
> Hi Everyone,
>
> I would like to have the following change reviewed:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8161696
>
> Webrev:http://cr.openjdk.java.net/~gthornbr/8161696/hotspot-webrev.01/ 
> <http://cr.openjdk.java.net/%7Egthornbr/8161696/hotspot-webrev.01/>

test/runtime/StackGuardPages/exeinvoke.c
     No comments.


> The stack size for this test needs to be increased to 384K for some 
> platforms.
> My fix for JDK-8081770 
> https://bugs.openjdk.java.net/browse/JDK-8081770 moved the functionality
> from the testme.sh script to exeinvoke.c so the dependency for a local 
> compiler could be removed.
> Because of this the stack size change needs to be applied to 
> exeinvoke.c file instead of the testme.sh file.
>
> Please let me know if you have any questions or concerns.

It took me a little bit to figure out how this failure started happening
in the first place. My guess is that your fix for JDK-8081770 made it
so that the test was now runnable on ARM64, where before it wouldn't
run because of the local compiler dependency. Now that a local compiler
is not needed, the original -Xss320k is discovered to be insufficient
on ARM64. Do I have all this right?

Thumbs up pending a reply that shows you have done adequate testing on
this fix.

Dan


>
> Thanks,
>
> Jerry